• davel [he/him]@lemmy.ml
    link
    fedilink
    English
    arrow-up
    12
    arrow-down
    2
    ·
    10 hours ago

    A lot of these should not be called breaking changes. A new API is not a breaking change if the old API remains.

  • db0@lemmy.dbzer0.com
    link
    fedilink
    English
    arrow-up
    40
    ·
    14 hours ago

    Oof, lots of work to do for everyone.

    If anyone can figure out all the non-mentioned API changes and write them here it would be useful for people like me to avoid having to reverse engineer things

    • Dessalines@lemmy.mlM
      link
      fedilink
      English
      arrow-up
      40
      ·
      13 hours ago

      Lots of things, but mainly that lemmy is pretty stable, and its been a year since the last breaking changes release.

      I was also kind of opposed to a v1.0, and wanted lemmy to be considered alpha/beta level software, because I know when we release a v.1.0, people are going to expect the same enterprise-level and bug-free software from a ~4 person dev team as they do from a multi-million dollar company. Also it gives us less freedom to make breaking changes, which can be restrictive for back-end devs.

      But now we can just adopt proper semver, and the next breaking changes releases can upgrade the MAJOR version.

      • nutomic@lemmy.mlOPM
        link
        fedilink
        English
        arrow-up
        5
        ·
        8 hours ago

        On the other hand it gives an indication to client developers that such big breaking changes wont be a regular occurence. So they have a reason to upgrade and then keep using 1.0 long-term. I believe that practically all the needed breaking changes are already implemented, and remaining issues are mostly new feature requests which can be added as new api endpoints or parameters.

  • sabreW4K3@lazysoci.al
    link
    fedilink
    English
    arrow-up
    8
    ·
    12 hours ago

    This is epic. I really hope Laurence can find some time to make Sync for Lemmy support it.

    • Dessalines@lemmy.mlM
      link
      fedilink
      English
      arrow-up
      15
      ·
      13 hours ago

      Can’t give an ETA yet. I’ve got a few more back-end things to finish up, then @sleeplessone1917 and I will work on lemmy-ui.

      Then I also gotta work on getting jerboa updated also. So much work and so few developers.

      • aeharding@vger.social
        link
        fedilink
        English
        arrow-up
        6
        ·
        10 hours ago

        Awesome works!

        Only thing I’ve noticed so far is the old v3 profile API response doesn’t have posts/comments attached

        • Dessalines@lemmy.mlM
          link
          fedilink
          English
          arrow-up
          3
          ·
          10 hours ago

          Yep I think we note that in the breaking changes post. We only serve the combined responses now.

      • db0@lemmy.dbzer0.com
        link
        fedilink
        English
        arrow-up
        4
        ·
        13 hours ago

        Ah, good to know before I start developing. Can you let me know when we can start the development as I don’t want to use the API and then discover it’s missing more PRs?

        • Dessalines@lemmy.mlM
          link
          fedilink
          English
          arrow-up
          1
          ·
          12 hours ago

          I can’t say yet, as we’re still adding things. If you’re not using lemmy-js-client, then as long as your types are generated from it’s main branch directly, then you should be fine.

          • db0@lemmy.dbzer0.com
            link
            fedilink
            English
            arrow-up
            3
            ·
            edit-2
            12 hours ago

            I’m not using the js-client. I’m updating pythorhead so I need to make sure the API is at the final version before I can match it. And to match it I need the patches to be in so I can read the doc, and/or import the swagger.

            I will do what I can in advance, but to do the pre-development you asked for, we do need the final version up somewhere.

            • nutomic@lemmy.mlOPM
              link
              fedilink
              English
              arrow-up
              2
              ·
              8 hours ago

              The final api version would probably be in 1.0-beta.0, which will still take a few months. But at this time you can already start to adapt for the major changes like combined endpoints, and give feedback if anything else in the api needs changing.